878419 - Syntax error in make_incremental_updates.py since bug 841094

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Florian Quèze [:florian]]

Attachment: Patch

Since we updated Instantbird to use Mozilla 21 (https://bugzilla.instantbird.org/show_bug.cgi?id=1956), nightly builds are broken because partial mar files fail to be generated, with this python error:

  File "/Users/buildbot/buildslave/macosx/build/mozilla/tools/update-packaging/make_incremental_updates.py", line 45
    m = re.match("((?:|.*/)distribution/extensions)/", filename):
                                                                ^
SyntaxError: invalid syntax

Comment 1

[Robert Strong (they/them - no direct email)]

Comment on attachment 756958 [details] [diff] [review]
Patch

I suspect that Mike's python knowledge is greater than mine so pushing the review over to him.

nthomas, have we been seeing this internally as well and if we haven't do you know why?

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

We don't exercise that logic at all for Firefox or Thunderbird.

Comment 3

[Florian Quèze [:florian]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4f4a4ae3629d

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4f4a4ae3629d

Comment 5

[Florian Quèze [:florian]]

Comment on attachment 756958 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 841094
User impact if declined: No end-user impact, but it's an annoyance for users of make_incremental_updates.py and it would be great to no longer have to work around it in Mozilla 22.
Testing completed (on m-c, etc.): The patch here is currently applied after checking out the mozilla source code when building Instantbird nightlies.
Risk to taking this patch (and alternatives if risky): None; apparently it's not part of the Firefox and Thunderbird builds. It's even possible Instantbird is the only consumer as this bug hasn't been noticed before we updated to Mozilla 21.
String or IDL/UUID changes made by this patch: none.

Comment 6

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 756958 [details] [diff] [review]
Patch

a=nptob

Comment 7

[Florian Quèze [:florian]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/379d74d79b50
https://hg.mozilla.org/releases/mozilla-beta/rev/0def37e9cb35