661288 - Check mark not visible when hovering a disabled checked menuitem

Status: RESOLVED FIXED

(Toolkit :: Themes, defect)

Description

[Florian Quèze [:florian]]

Attachment: Patch

It seems this problem appeared with http://hg.mozilla.org/mozilla-central/rev/9b4420523d0c / Bug 542192.

The icon used for hovered checked menuitems has the same color as the background of not-hovered items, which makes it completely invisible for disabled items that aren't highlighted on hover.

Comment 1

[Mounir Lamouri (:mounir)]

Pushed:
http://hg.mozilla.org/mozilla-central/rev/a2007c44b669

Comment 2

[Vlad [QA]]

How can I verify this? Can you please provide some STR.
Thanks

Comment 3

[Florian Quèze [:florian]]

(In reply to Vlad [QA] from comment #2)
> How can I verify this? Can you please provide some STR.
> Thanks

The only STR I have are with Instantbird:
- Have a contact list with at least 2 different tags.
- Hide a tag.
- In the context menu of a tag, open the "Visible Tags…" sub-menu.
- The last item of that sub-menu ("Other Tags") is both checked and disabled. When hovering it, the check mark disappears.
This can be reproduced with Instantbird 1.0 and the current nightlies (still on Mozilla 6). We haven't produced mozilla7-based nightlies yet, so it's not possible to verify the fix right now with these STR without compiling oneself.

I tried to create a data URL for a XUL document containing a disabled checked menuitem to provide a very easy way to reproduce, but XUL documents are apparently no longer supported in data URLs :(.

Comment 4

[Vlad [QA]]

Hi Florian.
You said in comment3 that this can't be verify yet.
Is there a fix a some new STR?
Thanks